sungwy commented on code in PR #15750:
URL: https://github.com/apache/iceberg/pull/15750#discussion_r3580948741
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3734,6 +3734,50 @@ components:
type: array
items:
$ref: '#/components/schemas/StorageCredential'
+ labels:
+ $ref: '#/components/schemas/Labels'
+
+ Labels:
+ type: object
+ description: |
+ Catalog-provided metadata enrichment (for example ownership,
+ classification, or cost attribution) returned with a table or view.
+ Labels are ephemeral: catalog-owned, generated per request, and never
+ persisted to table metadata or versioned with table history. Optional;
+ clients may ignore them. Labels are catalog-specific; different
catalogs
+ may return different or no labels for the same object. `table` carries
Review Comment:
If that's the case, I lean towards removing this statement:
> Labels are catalog-specific; different catalogs may return different or no
labels for the same object.
This sounds like a catalog implementation concern, and applies to all other
constructs that are returned through catalog as well. I don't see anything
specifically unique about `Labels` over other catalog returned constructs (like
`StorageCredential`, or even `TableMetadata`) that warrants us putting this
disclaimer any more than the others. It feels like we are saying something too
obvious like `cats are mammals`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
