nastra commented on code in PR #15750:
URL: https://github.com/apache/iceberg/pull/15750#discussion_r3585507695


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3734,6 +3734,50 @@ components:
           type: array
           items:
             $ref: '#/components/schemas/StorageCredential'
+        labels:
+          $ref: '#/components/schemas/Labels'
+
+    Labels:
+      type: object
+      description: |
+        Catalog-provided metadata enrichment (for example ownership,
+        classification, or cost attribution) returned with a table or view.
+        Labels are ephemeral: catalog-owned, generated per request, and never
+        persisted to table metadata or versioned with table history. Optional;
+        clients may ignore them. Labels are catalog-specific; different 
catalogs
+        may return different or no labels for the same object. `table` carries
+        entity-level labels; `columns` is an array of per-column entries, each
+        identifying its column by field-id.
+      properties:
+        table:
+          type: object
+          description: Top-level entity labels (attached to the catalog object 
as a whole).
+          additionalProperties:
+            type: string
+        columns:
+          type: array
+          description: >-
+            Column-level labels. Each entry identifies its column by field-id.
+          items:
+            $ref: '#/components/schemas/ColumnLabels'

Review Comment:
   the main thing I wanted to avoid is to send multiple fields in 
`LoadTableResult` that represent different type of labels. Hence why I proposed 
to send only a single `labels` field in `LoadTableResult`. That field can then 
carry different type of specific labels.
   I think it also makes sense to bring this up in the next catalog sync



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to