stevenzwu commented on code in PR #17198: URL: https://github.com/apache/iceberg/pull/17198#discussion_r3582578545
########## format/spec.md: ########## @@ -700,6 +700,10 @@ The `sequence_number` field represents the data sequence number and must never c The `file_sequence_number` field represents the sequence number of the snapshot that added the file and must also remain unchanged upon assigning at commit. The file sequence number can't be used for pruning delete files as the data within the file may have an older data sequence number. The data and file sequence numbers are inherited only if the entry status is 1 (added). If the entry status is 0 (existing) or 2 (deleted), the entry must include both sequence numbers explicitly. +#### Content file uniqueness + +Within a snapshot, each live manifest entry must be uniquely defined by `file_path` across all manifest files. A snapshot with multiple live entries for the same `file_path` has undefined behavior. Writers are not required to validate uniqueness because doing so can be expensive at commit time. Review Comment: Anoop's framing makes sense to me. I agree that we don't mention the field name. not sure if we need to clarify the meaning of `the same file location` in the context of mixed absolute and relative path. wondering if we should just drop this sentence from Anoop's suggested text. ``` Entries reference the same content file if they have the same file location, even if other field values differ. ``` ########## format/spec.md: ########## @@ -700,6 +700,10 @@ The `sequence_number` field represents the data sequence number and must never c The `file_sequence_number` field represents the sequence number of the snapshot that added the file and must also remain unchanged upon assigning at commit. The file sequence number can't be used for pruning delete files as the data within the file may have an older data sequence number. The data and file sequence numbers are inherited only if the entry status is 1 (added). If the entry status is 0 (existing) or 2 (deleted), the entry must include both sequence numbers explicitly. +#### Content file uniqueness Review Comment: is the placement of this section correct? it separates the `Notes` from line 707 with the previous section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
