stevenzwu commented on code in PR #17144:
URL: https://github.com/apache/iceberg/pull/17144#discussion_r3581797097
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -387,18 +471,23 @@ private static PartitionData partition(String category) {
/** Minimal file with no tracking, used by the rejection and null-tracking
tests. */
private static TrackedFileStruct dummyTrackedFile(FileContent contentType) {
- TrackedFileStruct file = new TrackedFileStruct();
- file.set(CONTENT_TYPE_ORDINAL, contentType.id());
- return file;
- }
-
- private static void populateTrackingFields(TrackedFile file) {
- TrackingStruct tracking = (TrackingStruct) file.tracking();
- tracking.set(DATA_SEQUENCE_NUMBER_ORDINAL, DATA_SEQUENCE_NUMBER);
- tracking.set(FILE_SEQUENCE_NUMBER_ORDINAL, FILE_SEQUENCE_NUMBER);
- tracking.set(FIRST_ROW_ID_ORDINAL, FIRST_ROW_ID);
- tracking.setManifestLocation(MANIFEST_LOCATION);
- tracking.set(MANIFEST_POS_ORDINAL, MANIFEST_POS);
+ return new TrackedFileStruct(
+ null,
Review Comment:
Real-ish placeholders like `FORMAT_VERSION_V4`, `"s3://bucket/file"`,
`FileFormat.PARQUET`, `1L`, `1L` (matching the pattern used elsewhere in this
file) read as "obviously a fixture". This would also match the behavior prior
to [PR
16769](https://github.com/apache/iceberg/pull/16769/changes#diff-fc382f17c4ec991bab0102083d77fb7820e05f4ebb05cbaf7100cd4ed88c8dd4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
