amogh-jahagirdar commented on code in PR #17144:
URL: https://github.com/apache/iceberg/pull/17144#discussion_r3596167818
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -208,18 +225,37 @@ void testDVDeleteFileAdapterDelegation() {
.cardinality(10L)
.build();
+ TrackingStruct tracking =
+ new TrackingStruct(
+ EntryStatus.ADDED,
+ 42L,
+ DATA_SEQUENCE_NUMBER,
+ FILE_SEQUENCE_NUMBER,
+ 42L,
+ FIRST_ROW_ID,
+ null,
+ null);
+ tracking.setManifestLocation(MANIFEST_LOCATION);
+ tracking.set(MANIFEST_POS_ORDINAL, MANIFEST_POS);
+
TrackedFile file =
- TrackedFileBuilder.data(42L)
- .formatVersion(FORMAT_VERSION_V4)
- .location(DATA_FILE_LOCATION)
- .fileFormat(FileFormat.PARQUET)
- .partition(PARTITION)
- .recordCount(100L)
- .fileSizeInBytes(1024L)
- .specId(PARTITIONED_SPEC_ID)
- .deletionVector(dv)
- .build();
- populateTrackingFields(file);
+ new TrackedFileStruct(
Review Comment:
I think this is OK just by virtue of the naming of the parameters we pass in
making it clear what each one is (except for some of the numeric values where
it's a bit hard to parse) but I think generally in the project we generally
want to aim for clarity in a manner that doesn't require an IDE to figure out,
especially as @stevenzwu said these days very few people are even opening those
up anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
