rambleraptor commented on code in PR #1463:
URL: https://github.com/apache/iceberg-go/pull/1463#discussion_r3582846273
##########
table/sorting.go:
##########
@@ -320,6 +320,10 @@ func newSortOrder(orderID int, fields []SortField,
validateSourceIDs bool) (Sort
return SortOrder{}, fmt.Errorf("%w: sort field
at index %d has invalid source IDs: %v",
ErrInvalidSortSourceID, idx, err)
}
+ if u, ok := field.Transform.(iceberg.UnknownTransform);
ok {
Review Comment:
Originally, I was thinking that we should be stricter than Java and then
could open it up in a follow-up PR. Let's go ahead and tolerate it instead.
It's better to stick with the reference implementation than figure out the
rejection logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
