rambleraptor commented on code in PR #1463:
URL: https://github.com/apache/iceberg-go/pull/1463#discussion_r3582851610
##########
transforms.go:
##########
@@ -77,7 +84,9 @@ func ParseTransform(s string) (Transform, error) {
return HourTransform{}, nil
}
- return nil, fmt.Errorf("%w: %s", ErrInvalidTransform, s)
+ // Unknown transform: v3 readers must load these and ignore them when
+ // filtering instead of failing. Keep the original string so it
round-trips.
+ return UnknownTransform{name: s}, nil
Review Comment:
I kept the behavior + added a comment. I double checked Java and it appears
to do a byte-for-byte check as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
