rdblue commented on code in PR #16958:
URL: https://github.com/apache/iceberg/pull/16958#discussion_r3583407605
##########
core/src/main/java/org/apache/iceberg/Partitioning.java:
##########
@@ -243,6 +243,17 @@ public static StructType partitionType(Table table) {
"table partition", specs, allActiveFieldIds(table.schema(), specs));
}
+ /**
+ * Builds a unified partition type containing all partition fields from the
given specs, including
+ * fields whose source columns are no longer present in the table schema.
+ *
+ * @param specs the partition specs to unify
+ * @return the constructed unified partition type
+ */
+ static StructType partitionType(Collection<PartitionSpec> specs) {
Review Comment:
I think that this needs to be distinguished from the method above, which is
also called `partitionType`. It isn't obvious when to use that one vs this one
(other than convenience of using a `Table` vs specs). I think that this should
be renamed to `unionPartitionTypes` because it is a union of all partition
fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
