anoopj commented on code in PR #16958:
URL: https://github.com/apache/iceberg/pull/16958#discussion_r3589281232
##########
core/src/main/java/org/apache/iceberg/TrackedFileStruct.java:
##########
@@ -34,7 +34,10 @@
class TrackedFileStruct extends SupportsIndexProjection implements
TrackedFile, Serializable {
private static final Types.StructType EMPTY_STRUCT_TYPE =
Types.StructType.of();
- private static final Types.StructType BASE_TYPE =
+ // Package-private only so tests can look up positional ordinals. Unlike
+ // TrackedFile.schemaWithContentStats, the base layout always includes the
partition and
+ // content_stats positions.
Review Comment:
That is a better design. Changed to return `UnknownType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
