mxm commented on code in PR #17210:
URL: https://github.com/apache/iceberg/pull/17210#discussion_r3585840168
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java:
##########
@@ -279,6 +278,17 @@ public void append() throws IOException {
try (TableLoader loader = tableLoader.clone()) {
loader.open();
String tableName = loader.loadTable().name();
+ if (uidSuffix == null) {
+ this.uidSuffix =
+ "TableMaintenance-"
+ + tableName
+ + "-"
+ + taskBuilders.stream()
+ .map(MaintenanceTaskBuilder::maintenanceTaskName)
+ .sorted()
+ .collect(Collectors.joining("_"));
+ }
Review Comment:
The drawback of this approach is that, you won't be able to add new
maintenance tasks or drop existing ones (using the `allowNonRestoredState`
option), without discarding existing checkpoints/savepoints. I'm wondering
whether we should use a static default uid instead, or the table name like in
IcebergSink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
