mxm commented on code in PR #17210:
URL: https://github.com/apache/iceberg/pull/17210#discussion_r3594890924
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java:
##########
@@ -279,6 +278,17 @@ public void append() throws IOException {
try (TableLoader loader = tableLoader.clone()) {
loader.open();
String tableName = loader.loadTable().name();
+ if (uidSuffix == null) {
+ this.uidSuffix =
+ "TableMaintenance-"
+ + tableName
+ + "-"
+ + taskBuilders.stream()
+ .map(MaintenanceTaskBuilder::maintenanceTaskName)
+ .sorted()
+ .collect(Collectors.joining("_"));
+ }
Review Comment:
>Do you mean remove maintenanceTaskName only use table name ?
Yes.
>Initially I considered using only the table name. But considering that
there might be two independent tasks running within a single Flink job, which
would cause a conflict, I added the maintenanceTaskName.
The same would be true for multiple instances of IcebergSink. Maybe ok to
force the user to set an explicit UID for these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
