fallintoplace opened a new pull request, #1471: URL: https://github.com/apache/iceberg-go/pull/1471
## Summary - clone blob field IDs and properties before validation and storage - return separate metadata copies so callers cannot mutate the pending footer - verify mutations through both the input and returned metadata leave serialized metadata unchanged ## Why `AddBlob` retained caller-owned slices and maps after validating them. A caller could mutate either the input or returned `BlobMetadata` before `Finish`, causing the writer to serialize values that never passed validation. ## Testing - focused ownership and writer validation tests repeated 20 times - `go test ./puffin` - `go vet ./puffin` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
