smaheshwar-pltr commented on code in PR #16796:
URL: https://github.com/apache/iceberg/pull/16796#discussion_r3591659482
##########
docs/docs/maintenance.md:
##########
@@ -78,6 +78,8 @@ Untracked metadata files are also deleted as part of [orphan
file deletion](#del
| write.metadata.delete-after-commit.enabled | false | Controls
whether to delete the oldest **tracked** version metadata files after each
table commit |
| write.metadata.previous-versions-max | 100 | The max
number of previous version metadata files to track
|
+Setting `write.metadata.previous-versions-max=0` keeps no previous metadata
files, so the `metadata-log` is always empty. With
`write.metadata.delete-after-commit.enabled=true`, the superseded metadata file
is deleted on every commit, leaving only the current metadata file; lowering
the property to `0` also deletes any files still tracked in the existing
`metadata-log` on the next commit.
Review Comment:
IMHO, the orphaning isn't specific to a value of 0; with
delete-after-commit.enabled=false, superseded metadata files are never cleaned
at _any_ `previous-versions-max` value.
It's the documented behaviour of that flag, so I suspect it'd be even more
confusing to single out the 0 case. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
