smaheshwar-pltr commented on PR #16796: URL: https://github.com/apache/iceberg/pull/16796#issuecomment-4986671598
> One thing that's worth a note rather than a blocker: with =0, the commit-status recovery in BaseMetastoreTableOperations that scans previousFiles() loses its fallback, so a transient catalog error after the metadata file is persisted has a weaker recovery story for metastore catalogs. Might be worth calling that out in the docs. Thanks for bringing this up - it does make sense to me generally call out this trade off for small values of this property, but similar to https://github.com/apache/iceberg/pull/16796#discussion_r3591659482, I'm unconvinced that this is new to the 0 case i.e. this still certainly held for a value of 1 before). Perhaps we could separate out the change here to point out that general tradeoff, so this PR stays isolated to what it claims to be (allowing a value of 0)? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
