wgtmac commented on code in PR #822:
URL: https://github.com/apache/iceberg-cpp/pull/822#discussion_r3593436540
##########
src/iceberg/data/file_scan_task_reader.cc:
##########
@@ -161,9 +165,9 @@ class FileScanTaskReader::Impl {
data_file->file_size_in_bytes);
if (task.delete_files().empty()) {
- auto options =
- MakeReaderOptions(*data_file, io_, projected_schema_,
task.residual_filter(),
- name_mapping_, properties_);
+ auto options = MakeReaderOptions(
Review Comment:
I just let Codex create these to provide me with more detail so I marked
them as `[DO NOT REVIEW]`. Feel free to create your own PRs if you have time to
work on them :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
