manuzhang commented on code in PR #822:
URL: https://github.com/apache/iceberg-cpp/pull/822#discussion_r3601001166
##########
src/iceberg/catalog/rest/json_serde.cc:
##########
@@ -323,6 +323,9 @@ Result<std::vector<std::shared_ptr<FileScanTask>>>
FileScanTasksFromJson(
GetJsonValue<nlohmann::json>(task_json,
kDataFile));
ICEBERG_ASSIGN_OR_RAISE(
auto data_file, DataFileFromJson(data_file_json, partition_spec_by_id,
schema));
+ // FIXME: REST scan-task DataFile JSON currently carries first-row-id,
Review Comment:
@wgtmac Can we add a test that exposes this gap and we skip for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
