kinolaev commented on PR #17196: URL: https://github.com/apache/iceberg/pull/17196#issuecomment-4995473065
> As is, we are creating a function which other libraries could use but would produce records or schema which wouldn't work properly when the rest of this library worked with them. I've read this a second time and now understand: you are talking only about the core library, not about all Iceberg libraries (including Spark and Flink integrations), right? That makes the problem much simpler... I changed my mind and took a look at the data side :) I copied most of the changes from the @AnatolyPopov's PR #15437 (including changes to `BaseWriteBuilder`, `GenericAvroReader` and `InternalReader`), added corresponding changes to `DataWriter`, and passed `legacyTimestampMapping` to all `AvroSchemaUtil.isTimestamptz` calls. Here is the result: c1058a57003ac43dd386eed103966d5604fabcb0. Am I correct in understanding that tests for these changes are the only missing piece now, @RussellSpitzer ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
