RussellSpitzer commented on PR #17196: URL: https://github.com/apache/iceberg/pull/17196#issuecomment-4993633565
I'm not sure why we would keep it scoped to just this class? As is, we are creating a function which other libraries could use but would produce records or schema which wouldn't work properly when the rest of this library worked with them. So for example if you wanted to change SchemaToType in isolation I think that's pretty safe. We never would create output that would break other parts of the library. The moment we touch TypeToSchema we are potentially producing records that would break the rest of the library. So I think we either follow the path of [#Unknown and TimestampNanos](https://github.com/apache/iceberg/pull/12455) Or restrict the changes here just to the read side. Personally I think just fixing everything is the right move here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
