rdblue commented on code in PR #17159:
URL: https://github.com/apache/iceberg/pull/17159#discussion_r3598756731
##########
core/src/main/java/org/apache/iceberg/MetricsUtil.java:
##########
@@ -531,8 +534,11 @@ static Map<Integer, ByteBuffer> lowerBounds(ContentStats
stats) {
Map<Integer, ByteBuffer> result = Maps.newHashMap();
for (FieldStats<?> fs : stats.fieldStats()) {
- if (fs != null && fs.lowerBound() != null && fs.type() != null) {
- result.put(fs.fieldId(), Conversions.toByteBuffer(fs.type(),
fs.lowerBound()));
+ if (fs != null) {
+ Type boundType = fs.type().fieldType("lower_bound");
+ if (fs.lowerBound() != null && boundType != null) {
+ result.put(fs.fieldId(), Conversions.toByteBuffer(boundType,
fs.lowerBound()));
Review Comment:
MetricsUtil conversions are placeholders. This was already a problem. It was
just hidden before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
