tanmayrauth commented on code in PR #1430:
URL: https://github.com/apache/iceberg-go/pull/1430#discussion_r3599426354
##########
catalog/hadoop/hadoop.go:
##########
@@ -549,12 +557,18 @@ func (c *Catalog) CreateTable(ctx context.Context, ident
table.Identifier, sc *i
c.writeVersionHint(ident, version)
+ reporter, err := c.reporter.Get(c.props)
Review Comment:
Moved resolution to construction. Hadoop resolves in NewCatalog; glue's
NewCatalog now returns (*Catalog, error) and resolves there too (updated the
registrar, CLI, and callers). A bad name now fails construction instead of a
post-write CreateTable, and since CachedReporter resolves once, no cached error
can wedge later ops. Test updated to pin construction-time failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
