thswlsqls commented on PR #17250: URL: https://github.com/apache/iceberg/pull/17250#issuecomment-5002316741
Fixed all of them except the two filter fields. `JsonUtil.getString`/`getBool`/`getStringMap` and `JsonUtil.get` all assert `!pNode.isNull()`, so an explicit null threw in each spot you listed — those now use `hasNonNull()` and each parser has a test for it. I left `PlanTableScanRequestParser.filter` and `RESTFileScanTaskParser.residual-filter` alone: #14657 added `testFilterFieldWithExplicitNullThrowsError` when it aligned `filter` with the OpenAPI spec, so the throw looks deliberate there, and treating a null filter as "no filter" would silently turn a malformed request into a full scan instead of an error. Happy to change those too if you'd rather have them consistent with the rest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
