huaxingao commented on code in PR #17250:
URL: https://github.com/apache/iceberg/pull/17250#discussion_r3632350592
##########
core/src/main/java/org/apache/iceberg/rest/requests/PlanTableScanRequestParser.java:
##########
@@ -116,12 +116,12 @@ public static PlanTableScanRequest fromJson(JsonNode
json) {
}
boolean caseSensitive = true;
- if (json.has(CASE_SENSITIVE)) {
+ if (json.hasNonNull(CASE_SENSITIVE)) {
Review Comment:
`filter` (line 114) still uses `has()` and throws on an explicit null, while
`case-sensitive` and `use-snapshot-schema` now tolerate it. Could we add a
one-line comment noting this is intentional — the throw aligns filter with the
OpenAPI spec? Same for RESTFileScanTaskParser (residual-filter vs
delete-file-references).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
