lawofcycles commented on code in PR #3320:
URL: https://github.com/apache/iceberg-python/pull/3320#discussion_r3609798316
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -499,8 +637,19 @@ def files_affected(self) -> bool:
"""Indicate if any manifest-entries can be dropped."""
return len(self._deleted_entries()) > 0
+ def _refresh_for_retry(self) -> None:
Review Comment:
Good catch. The delete now freezes its planned file set at plan time and
matches by membership on retry, so it no longer replans against a newer head.
Concurrent commits are preserved under snapshot isolation, and a concurrent
commit is treated atomically. This mirrors how _OverwriteFiles already resolves
its deletes from a fixed set. Added both of your tests as regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
