lawofcycles commented on code in PR #3320:
URL: https://github.com/apache/iceberg-python/pull/3320#discussion_r3611582375
##########
pyiceberg/table/__init__.py:
##########
@@ -1042,18 +1084,111 @@ def commit_transaction(self) -> Table:
Returns:
The table with the updates applied.
"""
+ if self._failed:
+ raise RuntimeError("This transaction failed to commit and cannot
be reused; create a new transaction.")
if len(self._updates) > 0:
- self._requirements +=
(AssertTableUUID(uuid=self.table_metadata.table_uuid),)
- self._table._do_commit( # pylint: disable=W0212
- updates=self._updates,
- requirements=self._requirements,
+ properties = self._table.metadata.properties
+ num_retries: int = max(
Review Comment:
Done, clamped the same way as num retries, with a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
