pvary commented on code in PR #17277:
URL: https://github.com/apache/iceberg/pull/17277#discussion_r3632206620
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java:
##########
@@ -109,16 +109,22 @@ public Builder cleanExpiredMetadata(boolean
newCleanExpiredMetadata) {
}
public Builder config(ExpireSnapshotsConfig expireSnapshotsConfig) {
- return
this.scheduleOnCommitCount(expireSnapshotsConfig.scheduleOnCommitCount())
+ this.scheduleOnCommitCount(expireSnapshotsConfig.scheduleOnCommitCount())
Review Comment:
If we do this way, we should make the whole method consistent.
```suggestion
scheduleOnCommitCount(expireSnapshotsConfig.scheduleOnCommitCount());
scheduleOnInterval(Duration.ofSeconds(expireSnapshotsConfig.scheduleOnIntervalSecond()));
deleteBatchSize(expireSnapshotsConfig.deleteBatchSize());
cleanExpiredMetadata(expireSnapshotsConfig.cleanExpiredMetadata());
planningWorkerPoolSize(expireSnapshotsConfig.planningWorkerPoolSize());
Integer retainLast = expireSnapshotsConfig.retainLast();
if (retainLast != null) {
retainLast(retainLast);
}
Long maxSnapshotAgeSeconds =
expireSnapshotsConfig.maxSnapshotAgeSeconds();
if (maxSnapshotAgeSeconds != null) {
maxSnapshotAge(Duration.ofSeconds(maxSnapshotAgeSeconds));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
