thswlsqls commented on code in PR #17277:
URL: https://github.com/apache/iceberg/pull/17277#discussion_r3635343215
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java:
##########
@@ -109,16 +109,22 @@ public Builder cleanExpiredMetadata(boolean
newCleanExpiredMetadata) {
}
public Builder config(ExpireSnapshotsConfig expireSnapshotsConfig) {
- return
this.scheduleOnCommitCount(expireSnapshotsConfig.scheduleOnCommitCount())
+ this.scheduleOnCommitCount(expireSnapshotsConfig.scheduleOnCommitCount())
Review Comment:
@pvary Thanks — agreed, made the method consistent: both `retainLast` and
`maxSnapshotAge` now use the same null-guard. The builder defaults both fields
to null, so skipping the call when the config value is null keeps the same
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
