amogh-jahagirdar commented on code in PR #17256:
URL: https://github.com/apache/iceberg/pull/17256#discussion_r3639668326
##########
open-api/src/test/java/org/apache/iceberg/rest/RESTCompatibilityKitCatalogTests.java:
##########
@@ -85,6 +85,11 @@ protected boolean supportsServerSideRetry() {
restCatalog.properties(),
RESTCompatibilityKitSuite.RCK_SUPPORTS_SERVERSIDE_RETRY, true);
}
+ @Override
+ protected boolean supportsVariant() {
+ return true;
Review Comment:
+1 to making this configurable and opt-in like the other overrides.
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -203,6 +204,10 @@ protected boolean supportsEmptyNamespace() {
return false;
}
+ protected boolean supportsVariant() {
+ return false;
+ }
Review Comment:
I would probably decouple the RCK test change PR from the actual spec change
just so it's not bounding the spec change on discussion around how the RCK
tests should look for a data type. The two are independent in that the protocol
officially just defining variant is independent of these tests; it's not like
the success or failure of the RCK tests against a catalog is going to change
the spec decision especially considering variant has been around for a while in
the table metadata format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
