nssalian commented on code in PR #17256:
URL: https://github.com/apache/iceberg/pull/17256#discussion_r3649479165
##########
open-api/rest-catalog-open-api.py:
##########
@@ -1902,8 +1906,8 @@ class Schema(StructType):
identifier_field_ids: list[int] | None = Field(None,
alias='identifier-field-ids')
-class Type(RootModel[PrimitiveType | StructType | ListType | MapType]):
- root: PrimitiveType | StructType | ListType | MapType
+class Type(RootModel[PrimitiveType | StructType | ListType | MapType |
VariantType]):
Review Comment:
fixed. Reordered the `Type` `oneOf` to put `VariantType` first and
regenerated - `model_validate("variant")` now resolves to `VariantType`,other
type strings still resolve to `PrimitiveType`. Kept `not: {const: variant}`
on `PrimitiveType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
