kevinjqliu commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3640229815
##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
configurations {
all {
resolutionStrategy {
- force
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
- force
"com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
- force
"com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+ force
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+ force
"com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+ force
"com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"
Review Comment:
each version of spark is using a different override right now
- spark v3.5 is currently using
[jackson215](https://github.com/apache/iceberg/blob/cd708ae33175fad24e0b4dc2f3395167662c1121/spark/v3.5/build.gradle#L33-L35)
- spark v4.0 is currently using
[jackson218](https://github.com/apache/iceberg/blob/cd708ae33175fad24e0b4dc2f3395167662c1121/spark/v4.0/build.gradle#L33-L35)
- spark v4.1 is currently using
[jackson221](https://github.com/apache/iceberg/blob/cd708ae33175fad24e0b4dc2f3395167662c1121/spark/v4.1/build.gradle#L33-L35)
Looks like the CVE suggests `2.18.8` as the minimum version,
https://github.com/advisories/GHSA-r7wm-3cxj-wff9
Should we use that instead of 2.21?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
