huaxingao commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3641495087
##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
configurations {
all {
resolutionStrategy {
- force
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
- force
"com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
- force
"com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+ force
"com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+ force
"com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+ force
"com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"
Review Comment:
Do we actually need this bump? The CVE (`GHSA-r7wm-3cxj-wff9`) is a DoS in
Jackson's async/non-blocking parser, which isn't used on Iceberg's parsing
paths (we use the blocking parser), and the jar is shaded — so it's not a
reachable issue for us, just a scanner finding we already suppress.
If we do want to fix it (e.g. to keep downstream scanners quiet), I'd lean
toward `2.18.8`: it's the minimal patched version that clears the finding
(Spark 4.0 ships it and needs no ignore), and it's the smallest jump from 3.5's
native `2.15.2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
