amogh-jahagirdar commented on code in PR #17347:
URL: https://github.com/apache/iceberg/pull/17347#discussion_r3645875842
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java:
##########
@@ -92,4 +92,8 @@ private SparkWriteOptions() {}
// Controls the buffer size for variant schema inference during writes
public static final String VARIANT_INFERENCE_BUFFER_SIZE =
"variant-inference-buffer-size";
+
+ // Uses the merge append instead of fast append for streaming appends
+ public static final String STREAMING_MERGE_APPEND_ENABLED =
"streaming-merge-append-enabled";
+ public static final boolean STREAMING_MERGE_APPEND_ENABLED_DEFAULT = false;
Review Comment:
I would be surprised too, and honestly I'd like to change the default here
as well but I think it's best for at least 1 release to keep the behavior and
then change it in the next. My rationale is mostly that it gives 1 release
cycle worth of time in case there are users who somehow rely or expect there to
be 1 manifest per commit (would be strange but sometimes when there's a
deterministic behavior in output folks may rely on that whenever they perform
some operations) or some other side effect of the fast append to be made aware
of the change and have time to adjust for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
