amogh-jahagirdar commented on PR #17347: URL: https://github.com/apache/iceberg/pull/17347#issuecomment-5070959478
>What about these properties? Enabling this would mean that we just use 1 and enable no? commit.manifest.min-count-to-merge commit.manifest-merge.enabled Not exactly, so these properties are currently respected under the condition that a merging manifest write is already being done. So this would be operations like overwrite, rowdelta, the merging append. What enabling this conf would do is is actually cause spark streaming appends to use the merging write, and then these properties would kick in. If someone were to then configure min-count-to-merge = 50, then it would be respected. Then someone could set the table property to disable manifest merge (though not recommended here) then the merging append wouldn't merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
