zeroshade commented on code in PR #1426:
URL: https://github.com/apache/iceberg-go/pull/1426#discussion_r3647331841
##########
table/equality_delete_writer.go:
##########
@@ -130,7 +130,10 @@ func (t *Transaction) WriteEqualityDeletes(ctx
context.Context, equalityFieldIDs
return nil, err
}
- arrowSc, err := SchemaToArrowSchema(deleteSchema, nil, true, false)
+ arrowSc, err := SchemaToArrowSchemaWithOptions(deleteSchema,
ArrowSchemaOptions{
Review Comment:
Non-blocking: this write path gets the projjson option plumbing but no
projjson-specific test; a follow-up assertion here (and for
position-delta/compaction/txn-rewrite) would guard against regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
