C-Loftus commented on PR #1426:
URL: https://github.com/apache/iceberg-go/pull/1426#issuecomment-5093274370

   @zeroshade your comments should be addressed now. 
   
     I added focused coverage for the equality-delete writer path. The test 
writes an equality delete on a geometry(projjson:...) key and verifies the 
generated Parquet Arrow schema contains the resolved PROJJSON metadata from 
table properties. I kept compaction/position-delta out of this test because 
those route through the existing WriteRecords/schema-conversion paths; happy to 
add separate follow-up coverage if desired.
   
   I then renamed some of the `internal` references to `tblutils` for 
standardization as you requested and fixed any merge conflicts. Should be set 
to review again. 
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to