cccs-jc commented on a change in pull request #1979:
URL: https://github.com/apache/iceberg/pull/1979#discussion_r551065211
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -139,6 +139,25 @@ public String name() {
return catalogName;
}
+ private boolean isTableDir(Path path) {
+ Path metadataPath = new Path(path, "metadata");
+ // Only the path which contains metadata is the path for table, otherwise
it could be
+ // still a namespace.
+ try {
+ return fs.listStatus(metadataPath, TABLE_FILTER).length >= 1;
+ } catch (IOException e) {
+ return false;
Review comment:
Hey Ryan, sorry for the late reply. Ya I'm thinking it could support a
flag passed in as a configuration via the org.apache.hadoop.conf.Configuration
I'm just not sure how to pass values into that configuration object. For
example there is already a FILE_IO_IMPL supported. How would I add an
additional configuration like FILE_IO_IMPL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
