cccs-jc commented on pull request #1979:
URL: https://github.com/apache/iceberg/pull/1979#issuecomment-755543018
I've checked everywhere the following methods are used
isTableDir
isDirectory
isNamespace
In all cases I can see it makes sense to not throw the exception since these
are tests. For example
createNamespace()
if isNamespace
throw AlreadyExistsException
if it does not exists it will try to create it.
if a user for some reason can't list the dir it will return false and
proceed to try to create it, at that point it will fail with a IOException
showing why (could be restricted access or any other reason)
listNamespaces()
if not isNamespace
throws NoSuchNamespaceException
then proceeds to list the namespaces under that location, so like
listTables it might be a partial list
dropNamespace()
if can't access it will consider it does not exists and return false (not
dropped)
loadNamespaceMetadata
again if can't access namespace a NoSuchNamespaceException is returned
Nonetheless I will add checks for determining if the exception is an azure
blob exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
