laskoviymishka commented on code in PR #17337: URL: https://github.com/apache/iceberg/pull/17337#discussion_r3668471061
########## core/src/main/java/org/apache/iceberg/rest/labels/Labels.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.labels; + +import java.util.List; +import java.util.Map; +import org.immutables.value.Value; + +/** + * Catalog-provided metadata enrichment (for example ownership, classification, or cost attribution) + * returned alongside a table or view on the read path. + * + * <p>Labels are generated per request and optional; clients may ignore them. They are not part of + * table state: the spec does not require how a catalog produces or stores labels, nor whether they + * are persisted or versioned. {@link #object()} carries catalog-object-level labels; {@link + * #fields()} carries per-field labels, each identified by field id. + */ [email protected] +public interface Labels { + /** Catalog-object-level labels, attached to the object (table, view, ...) as a whole. */ + Map<String, String> object(); Review Comment: We discuss this here - https://github.com/apache/iceberg/pull/15750#discussion_r3579894016 I'm thinking we are close to alignment, i don't have strong preferences honestly, just want to ensure it works :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
