nastra commented on code in PR #17337:
URL: https://github.com/apache/iceberg/pull/17337#discussion_r3671737956
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -557,10 +558,11 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
}
List<Credential> credentials = response.credentials();
+ Labels labels = response.labels();
Review Comment:
this is probably ok to include REST-specific code here to show how
everything fits together, but we typically try to split the parsers from the
catalog integration. Maybe it would be better to have a stacked PR that just
builds on top of the parsers and shows catalog integration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
