smaheshwar-pltr commented on code in PR #17404:
URL: https://github.com/apache/iceberg/pull/17404#discussion_r3670102374
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -353,7 +353,9 @@ public String toString() {
this.snapshotsLoaded = snapshotsSupplier == null;
this.snapshotLog = snapshotLog;
this.previousFiles = previousFiles;
- this.encryptionKeys = encryptionKeys;
+ // Immutable so a built instance's key set is stable, which
HiveTableOperations relies on to
+ // memoize its metadata-sourced encryption manager by metadata identity.
Review Comment:
why? do we rlly need this? surely tablemetadata treats like immutable? wanna
avoid large copy (per-snapshot keys)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
