smaheshwar-pltr commented on code in PR #17404:
URL: https://github.com/apache/iceberg/pull/17404#discussion_r3670121273
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -203,62 +217,35 @@ the table key parameter (along with existing snapshots)
in the file, making the
throw new RuntimeException("Interrupted during refresh", e);
}
- refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries);
+ // Use plain fileIO, not io(): metadata isn't envelope-encrypted and io()
would re-enter
+ // refresh.
Review Comment:
hmm don't love this
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -203,62 +217,35 @@ the table key parameter (along with existing snapshots)
in the file, making the
throw new RuntimeException("Interrupted during refresh", e);
}
- refreshFromMetadataLocation(metadataLocation, metadataRefreshMaxRetries);
+ // Use plain fileIO, not io(): metadata isn't envelope-encrypted and io()
would re-enter
+ // refresh.
+ refreshFromMetadataLocation(
+ metadataLocation,
+ null,
+ metadataRefreshMaxRetries,
+ location -> TableMetadataParser.read(fileIO, location));
if (tableKeyIdFromHMS != null) {
checkIntegrityForEncryption(tableKeyIdFromHMS, dekLengthFromHMS,
metadataHashFromHMS);
- tableKeyId = tableKeyIdFromHMS;
- encryptionDekLength =
+ // Keys aren't cached here; encryption() rebuilds the manager from
metadata on demand.
Review Comment:
what does this comment give us
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
