smaheshwar-pltr commented on code in PR #17404:
URL: https://github.com/apache/iceberg/pull/17404#discussion_r3670135395
##########
spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/sql/TestTableEncryption.java:
##########
@@ -162,6 +162,29 @@ public void testConcurrentAppendTransactions() {
assertThat(currentDataFiles(table)).hasSize(dataFiles.size() + 2);
}
+ @TestTemplate
+ public void testSharedTableTransactionInterleavedWithDirectCommit() {
Review Comment:
changes in this file read weird to me, shouldn't this be the tests in
https://github.com/smaheshwar-pltr/iceberg/pull/14
https://github.com/smaheshwar-pltr/iceberg/pull/15 instead? i feel like those
tests are very useful, maybe this new one is too or the same as one of the prev
one. but concurrent append test w encryption is almost essential to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
