dramaticlly commented on code in PR #17256:
URL: https://github.com/apache/iceberg/pull/17256#discussion_r3685269267
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2510,6 +2516,7 @@ components:
Type:
oneOf:
+ - $ref: '#/components/schemas/VariantType'
Review Comment:
I think this is a bit fragile in a sense that oneOf evaluated from top to
bottom and the PrimitiveType has a not variant to exclude. Might worth a
comment to avoid future alphabetic ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
