szehon-ho commented on code in PR #17256:
URL: https://github.com/apache/iceberg/pull/17256#discussion_r3686845641
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2423,12 +2423,18 @@ components:
PrimitiveType:
type: string
+ not:
Review Comment:
The issue we wanted to solve was
https://github.com/apache/iceberg/pull/17256#discussion_r3686095445 make it
stronger against future changes. yea we would need regex for that case..
the alternate is the comment then, which is ok , a bit ugly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]