kevinjqliu commented on code in PR #17256: URL: https://github.com/apache/iceberg/pull/17256#discussion_r3691823512
########## open-api/rest-catalog-open-api.yaml: ########## Review Comment: Right now the "variant" string matches both `PrimitiveType` and `VariantType`. the `not` will exclude this as a valid string in `PrimitiveType` > there's actually many things its 'not'. would a allowlist be better? This is the only string that matches both cases. This is a nit, I'd prefer to include the `not`, but I also think its fine as is. We dont need to bike shed here😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
