mj006648 opened a new pull request, #3745: URL: https://github.com/apache/iceberg-python/pull/3745
<!--\nThanks for opening a pull request!\n-->\n\n# Rationale for this change\n\nThe and commands used a truthy check for property lookups. As a result, an existing property with an empty string value was reported as missing.\n\nThis changes both lookups to check explicitly for , preserving empty strings while keeping the existing error for missing properties.\n\nRelated to #3713.\n\n## Are these changes tested?\n\nYes. Added CLI regression tests for empty table and namespace property values.\n\n- uv run prek run -a trim trailing whitespace.................................................Passed fix end of files.........................................................Passed check yaml...............................................................Passed check python ast.........................................................Passed ruff (legacy alias)......................................................Passed ruff format..............................................................Passed nbqa-ruff................................................................Passed mypy.....................................................................Passed markdownlint.............................................................Passed pydocstyle...............................................................Passed codespell................................................................Passed uv-lock..................................................................Passed\n- ============================= test session starts ============================== platform linux -- Python 3.12.3, pytest-9.1.1, pluggy-1.6.0 rootdir: /home/netai/iceberg-python configfile: pyproject.toml plugins: mock-3.15.1, requests-mock-1.12.1, checkdocs-2.14.0, lazy-fixtures-1.4.0, anyio-4.14.1 collected 84 items tests/cli/test_console.py .............................................. [ 54%] ...................................... [100%] ============================== 84 passed in 3.50s ==============================\n\n## Are there any user-facing changes?\n\nYes. The table and namespace property commands now return an existing empty string value instead of raising .\n\n<!-- In the case of user-facing changes, please add the changelog label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
