kevinjqliu commented on code in PR #3745:
URL: https://github.com/apache/iceberg-python/pull/3745#discussion_r3705634464


##########
pyiceberg/cli/console.py:
##########


Review Comment:
   slight nit: i think we can simplify this whole block like so
   
   ```
       if not property_name:
           output.describe_properties(namespace_properties)
           return
   
       property_value = namespace_properties.get(property_name)
       if property_value is None:
           raise NoSuchPropertyException(f"Could not find property 
{property_name} on namespace {identifier}")
   
       output.text(property_value)
   ```
   
   but this can be a follow up PR 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to