anoopj commented on code in PR #2952:
URL: https://github.com/apache/iceberg-rust/pull/2952#discussion_r3713684556
##########
crates/iceberg/src/scan/task.rs:
##########
@@ -67,6 +67,21 @@ pub struct FileScanTask {
#[builder(default)]
pub record_count: Option<u64>,
+ /// The first row id assigned to the data file.
+ ///
+ /// Used to derive the `_row_id` metadata column: for a row without an
+ /// explicit `_row_id`, it is this value plus the row's ordinal position.
+ #[serde(skip_serializing_if = "Option::is_none")]
+ #[builder(default)]
+ pub first_row_id: Option<i64>,
+
+ /// The data sequence number of the data file.
Review Comment:
Reworded to call out the data-vs-file distinction explicitly and noted the
null case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
