anoopj commented on code in PR #2952:
URL: https://github.com/apache/iceberg-rust/pull/2952#discussion_r3713662792
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -1862,6 +1940,60 @@ pub mod tests {
);
}
+ #[tokio::test]
+ async fn test_plan_files_carries_row_lineage_into_file_scan_task() {
+ let mut fixture = TableTestFixture::new();
+ fixture.setup_manifest_files().await;
+
+ let mut tasks: Vec<_> = fixture
+ .table
+ .scan()
+ .build()
+ .unwrap()
+ .plan_files()
+ .await
+ .unwrap()
+ .try_collect()
+ .await
+ .unwrap();
+
+ tasks.sort_by_key(|task| task.data_file_path.to_string());
+ assert_eq!(tasks.len(), 2);
+
+ // The added file inherits the current snapshot's data sequence number,
+ // the existing file keeps the one it was written with.
+ assert_eq!(tasks[0].data_sequence_number, Some(1));
Review Comment:
Done both. Pinned data_file_path next to each data_sequence_number
assertion so the file->value mapping is explicit and survives a fixture rename,
and moved the task len assert above the sort .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
