nssalian commented on code in PR #17500:
URL: https://github.com/apache/iceberg/pull/17500#discussion_r3715112161
##########
core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java:
##########
@@ -203,6 +204,10 @@ protected boolean supportsEmptyNamespace() {
return false;
}
+ protected boolean supportsVariant() {
+ return false;
Review Comment:
Thank you for taking a look @okumin . I did the following locally:
Ran the RCK downstream: built Iceberg from this branch, pointed
apache/hive's metastore-rest-catalog at it, and ran TestRESTCatalogNoneAuth.
The two variant tests skip via AssumptionViolatedException: [Catalog supports
the variant type], thus proving consumers that don't opt in are unaffected.
On the default: I'd keep it false. It's consistent with the other optional
capability flags (supportsNestedNamespaces, supportsServerSideRetry,
supportsEmptyNamespace all default
false; only baseline behaviors default true), and variant is a v3 capability
that not every implementation may support. Defaulting to true would turn these
into failures rather than skips for any existing RCK consumer until they
explicitly opt out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
