tasty0tomato commented on PR #3771:
URL: https://github.com/apache/iceberg-python/pull/3771#issuecomment-5228632498
Thanks for picking this up @ArjunPakhan!
The diff here only contains `tests/table/test_inspect.py` — there's no
change to
`pyiceberg/table/inspect.py`. On `main`, `_readable_bound` is still a plain
`from_bytes(field_type, bound)`, so `test_readable_bound_type_promotions`
should
fail with the same `struct.error`. Looks like the source change didn't make
it
into the commit.
Two notes for when it does:
- `_readable_bound` covers `files()` / `entries()` / `data_files()` /
`all_files()`, but `manifests()` decodes partition field summaries directly
via `from_bytes` (`inspect.py` L420-435) and would fail the same way if the
promoted column is an identity partition source.
- An end-to-end test doing a real promotion then calling `inspect.files()`
(the
repro in the issue — `SqlCatalog` + temp dir, no network) would keep the
call
sites from drifting apart again.
Happy to test a revised branch against the S3 Tables table where I hit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
